feat: use ilpy.expressions in motile Constraints #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we shouldn't make the return value of
for node, selection_indicator in selection_indicators.items():
# use selection_indicator hereassumes less familiarity with the internals than for node, index in selection_indicators.items():
# know what to do with an index |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 92.77% 92.47% -0.30%
==========================================
Files 30 30
Lines 747 718 -29
==========================================
- Hits 693 664 -29
Misses 54 54
|
tlambert03
changed the title
|
This is now ready for review @funkey |
|
Perfect, looks all good. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates most of the motile constraints and costs to use
ilpy.Expressionintroduced in funkelab/ilpy#9 and released in ilpy v0.3.0Another notable (API breaking) change is that indexing into a Variable (i.e.
Variable.__get_item__) now returns anilpy.Variableinstance, rather than an integer, as per #30 (comment). In many cases, thatVariablecan be used exactly as the integer could before (it can be cast to an int withint(), it can be used as an index in aSolution, etc...), but it can also be used to create expressions.